Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #96 #123

Closed
wants to merge 3 commits into from
Closed

Fix #96 #123

wants to merge 3 commits into from
+34,049 −17,335

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented May 13, 2020

Added:

  • The new power_state_mechanism_config attribute was added, and we can use it as a following:
resource "nutanix_virtual_machine" "vm1" {
  name         = "my-vm"
  cluster_uuid = local.cluster1

  num_vcpus_per_socket = 1
  num_sockets          = 1
  memory_size_mib      = 186

  power_state_mechanism_config {
    guest_transition_config {
      should_fail_on_script_failure = true
      enable_script_exec            = true
    }
    mechanism = "ACPI"
  }

}

Also, the following Terraform configuration can work with the old attributes that represented the above new configuration:

resource "nutanix_virtual_machine" "vm1" {
  name         = "my-vm"
  cluster_uuid = local.cluster1

  num_vcpus_per_socket = 1
  num_sockets          = 1
  memory_size_mib      = 186

  should_fail_on_script_failure = true
  enable_script_exec            = true
  power_state_mechanism         = "ACPI"
}

But now they are deprecated, and we don't recomend using them due to inconsistency and bugs that were fixed with this new change.

closes #96

PacoDw added 3 commits May 13, 2020 14:33
@PacoDw
fix: added new power_state_mechanism_config attribute to be use inste…
e431d08 
…ad of:

- should_fail_on_script_failure
- enable_script_exec
- power_state_mechanism
this change represents a better coherency with the API so the above attributes were deprecated, they can be used yet but we recommend
to use the new object power_state_mechanism_config
@PacoDw
chore: new test case was added to test the power_state_mechanism_conf…
1fe0b89 
…ig attribute
@PacoDw
chore: update vendor dependencies
cef4fd2
@ghost ghost added the size/XXL label May 13, 2020
@PacoDw PacoDw closed this May 13, 2020
@PacoDw PacoDw deleted the fix-#86 branch May 13, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

During a resource adjustment the VM is not shut down using ACPI
1 participant
@PacoDw